Просмотр исходного кода

Solve problem with subqueries in SELECT block

It solves executing queries with subqueries in SELECT block.
"New line" char (which is added in _renderFrom function while imploding joins) causes problem in regexp for "AS" case detection
Alex Komarov 10 лет назад
Родитель
Сommit
1396c59fb7
2 измененных файлов с 19 добавлено и 0 удалено
  1. 1 0
      library/Zend/Db/Select.php
  2. 18 0
      tests/Zend/Db/Select/StaticTest.php

+ 1 - 0
library/Zend/Db/Select.php

@@ -940,6 +940,7 @@ class Zend_Db_Select
             $currentCorrelationName = $correlationName;
             if (is_string($col)) {
                 // Check for a column matching "<column> AS <alias>" and extract the alias name
+                $col = str_replace("\n",'',$col);
                 if (preg_match('/^(.+)\s+' . self::SQL_AS . '\s+(.+)$/i', $col, $m)) {
                     $col = $m[1];
                     $alias = $m[2];

+ 18 - 0
tests/Zend/Db/Select/StaticTest.php

@@ -1011,4 +1011,22 @@ class Zend_Db_Select_StaticTest extends Zend_Db_Select_TestCommon
         $this->assertEquals($expected, $select->assemble());
     }
 
+    /**
+     * Test a problem with assembling subqueries with joins in SELECT block. That problem is caused by "new line" char which brakes regexp detection of "AS"-case
+     */
+    public function testAssembleQueryWithSubqueryInSelectBlock() {
+        $subSelect = $this->_db->select();
+        $subSelect->from(array('st1' => 'subTable1'), 'col1')
+                  ->join(array('st2' => 'subTable2'), 'st1.fk_id=st2.fk_id', 'col2');
+
+        $columns[] = '('.$subSelect->assemble() . ') as subInSelect';
+        $select = $this->_db->select();
+        $select->from(array('t' => 'table1'), $columns);
+
+        $expected = 'SELECT (SELECT "st1"."col1", "st2"."col2" FROM "subTable1" AS "st1" INNER JOIN "subTable2" AS "st2" ON st1.fk_id=st2.fk_id) AS "subInSelect" FROM "table1" AS "t"';
+
+        $this->assertEquals($expected, $select->assemble(),
+                            'Assembling query with subquery with join failed');
+    }
+
 }