Selaa lähdekoodia

ZF-11014 fix

git-svn-id: http://framework.zend.com/svn/framework/standard/trunk@23876 44c647ce-9c0f-0410-b52a-842ac1e357ba
jfaustin 14 vuotta sitten
vanhempi
commit
6806b1be4f
2 muutettua tiedostoa jossa 30 lisäystä ja 0 poistoa
  1. 8 0
      library/Zend/Service/Twitter.php
  2. 22 0
      tests/Zend/Service/Twitter/TwitterTest.php

+ 8 - 0
library/Zend/Service/Twitter.php

@@ -362,6 +362,14 @@ class Zend_Service_Twitter extends Zend_Rest_Client
                 case 'page':
                     $_params['page'] = (int) $value;
                     break;
+                case 'max_id':
+                    $_params['max_id'] = $this->_validInteger($value);
+                    break;
+                case 'include_rts':
+                case 'trim_user':
+                case 'include_entities':
+                    $_params[strtolower($key)] = $value ? '1' : '0';
+                    break;                    
                 default:
                     break;
             }

+ 22 - 0
tests/Zend/Service/Twitter/TwitterTest.php

@@ -648,6 +648,27 @@ class Zend_Service_Twitter_TwitterTest extends PHPUnit_Framework_TestCase
     }
 
     /**
+     * @group ZF-11014
+     */
+    public function testStatusFriendsTimelineShouldHonorAllFlags()
+    {
+        $params = array(
+            'page'             => 3,
+            'include_rts'      => '1',
+            'trim_user'        => '1',
+            'include_entities' => '1',
+        );
+        $twitter = new Zend_Service_Twitter();
+        $twitter->setLocalHttpClient($this->_stubTwitter(
+            'statuses/friends_timeline.xml', Zend_Http_Client::GET, 'statuses.friends_timeline.page.xml',
+            $params
+        ));  
+
+        // Assertions are part of mocking
+        $timeline = $twitter->statusFriendsTimeline($params);
+    }
+
+    /**
      * @group ZF-11023
      */
     public function testConstructorPassedObjectZendConfig()
@@ -657,6 +678,7 @@ class Zend_Service_Twitter_TwitterTest extends PHPUnit_Framework_TestCase
         $twitter = new Zend_Service_Twitter($config);
         $this->assertEquals('zf', $twitter->getUsername());
     }
+          
 }
 
 if (PHPUnit_MAIN_METHOD == 'Zend_Service_TwitterTest2::main') {