Browse Source

Added unit tests for Atom logo rendering in Zend_Feed_Writer

git-svn-id: http://framework.zend.com/svn/framework/standard/trunk@22099 44c647ce-9c0f-0410-b52a-842ac1e357ba
padraic 15 years ago
parent
commit
f6c94422a9

+ 2 - 2
library/Zend/Feed/Writer/Renderer/Feed/Atom/AtomAbstract.php

@@ -336,8 +336,8 @@ class Zend_Feed_Writer_Renderer_Feed_Atom_AtomAbstract
             return;
         }
         $img = $dom->createElement('logo');
-        $root->appendChild($image);
-        $text = $img->createTextNode($image['uri']);
+        $root->appendChild($img);
+        $text = $dom->createTextNode($image['uri']);
         $img->appendChild($text);
     }
     

+ 6 - 6
library/Zend/Feed/Writer/Renderer/Feed/Rss.php

@@ -355,13 +355,13 @@ class Zend_Feed_Writer_Renderer_Feed_Rss
         $img = $dom->createElement('image');
         $root->appendChild($image);
         $url = $dom->createElement('url');
-        $text = $url->createTextNode($image['uri']);
+        $text = $dom->createTextNode($image['uri']);
         $url->appendChild($text);
         $title = $dom->createElement('title');
-        $text = $title->createTextNode($image['title']);
+        $text = $dom->createTextNode($image['title']);
         $title->appendChild($text);
         $link = $dom->createElement('link');
-        $text = $link->createTextNode($image['link']);
+        $text = $dom->createTextNode($image['link']);
         $link->appendChild($text);
         $img->appendChild($url);
         $img->appendChild($title);
@@ -380,7 +380,7 @@ class Zend_Feed_Writer_Renderer_Feed_Rss
                 }
             }
             $height = $dom->createElement('height');
-            $text = $height->createTextNode($image['height']);
+            $text = $dom->createTextNode($image['height']);
             $height->appendChild($text);
             $img->appendChild($height);
         }
@@ -398,7 +398,7 @@ class Zend_Feed_Writer_Renderer_Feed_Rss
                 }
             }
             $width = $dom->createElement('width');
-            $text = $width->createTextNode($image['width']);
+            $text = $dom->createTextNode($image['width']);
             $width->appendChild($text);
             $img->appendChild($width);
         }
@@ -416,7 +416,7 @@ class Zend_Feed_Writer_Renderer_Feed_Rss
                 }
             }
             $desc = $dom->createElement('description');
-            $text = $desc->createTextNode($image['description']);
+            $text = $dom->createTextNode($image['description']);
             $desc->appendChild($text);
             $img->appendChild($desc);
         }

+ 14 - 0
tests/Zend/Feed/Writer/Renderer/Feed/AtomTest.php

@@ -403,4 +403,18 @@ class Zend_Feed_Writer_Renderer_Feed_AtomTest extends PHPUnit_Framework_TestCase
         $this->assertEquals($expected, (array) $feed->getHubs());
     }
 
+    public function testImageCanBeSet()
+    {
+        $this->_validWriter->setImage(
+            array('uri'=>'http://www.example.com/logo.gif')
+        );
+        $atomFeed = new Zend_Feed_Writer_Renderer_Feed_Atom($this->_validWriter);
+        $atomFeed->render();
+        $feed = Zend_Feed_Reader::importString($atomFeed->saveXml());
+        $expected = array(
+            'uri' => 'http://www.example.com/logo.gif'
+        );
+        $this->assertEquals($expected, $feed->getImage());
+    }
+
 }